Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: add config item "raw-min-ts-outlier-threshold" #9787

Merged
merged 7 commits into from Aug 5, 2022
Merged

tikv: add config item "raw-min-ts-outlier-threshold" #9787

merged 7 commits into from Aug 5, 2022

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Aug 1, 2022

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@TomShawn TomShawn requested a review from Oreoxmt August 1, 2022 11:38
@TomShawn TomShawn requested review from pingyu and removed request for shichun-0415 August 1, 2022 11:38
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2022
@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.2 This PR/issue applies to TiDB v6.2. area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 1, 2022
pingyu
pingyu approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

pingyu
pingyu reviewed Aug 1, 2022
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
@TomShawn @pingyu
Update tikv-configuration-file.md
905da86 
Co-authored-by: Ping Yu <shui.yu@126.com>
@pingyu
Copy link
Contributor

pingyu commented Aug 3, 2022

@sunxiaoguang PTAL, thanks~

Oreoxmt
Oreoxmt approved these changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b29305a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/rebase

TomShawn and others added 2 commits August 5, 2022 05:29
@TomShawn @pingyu
Update tikv-configuration-file.md
420f72b 
Co-authored-by: Ping Yu <shui.yu@126.com>
@TomShawn @Oreoxmt
Apply suggestions from code review
9ed78d8 
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9ed78d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/rebase

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/rebase

@TomShawn
Copy link
Contributor Author

TomShawn commented Aug 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c0139f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2022
@ti-chi-bot ti-chi-bot merged commit 20b375f into pingcap:master Aug 5, 2022
@TomShawn TomShawn deleted the raw-min-ts-out branch August 5, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pingyu pingyu pingyu approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@sunxiaoguang sunxiaoguang Awaiting requested review from sunxiaoguang

Assignees
No one assigned
Labels
area/engine Indicates that the Issue or PR belongs to the area of TP storage or Cloud storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TomShawn @ti-chi-bot @pingyu @Oreoxmt