Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard: add the monitoring page #9810

Merged
merged 4 commits into from Aug 10, 2022
Merged

dashboard: add the monitoring page #9810

merged 4 commits into from Aug 10, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented Aug 3, 2022 •
edited

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. v6.2 This PR/issue applies to TiDB v6.2. and removed missing-translation-status This PR does not have translation status info. labels Aug 3, 2022
@shichun-0415 shichun-0415 requested review from lilyjazz, YiniXu9506 and ran-huang and removed request for YiniXu9506 August 4, 2022 08:45
shichun-0415
shichun-0415 commented Aug 4, 2022
View reviewed changes
TOC.md Outdated Show resolved Hide resolved
@shichun-0415
Copy link
Contributor Author

shichun-0415 commented Aug 4, 2022 •
edited

@ran-huang @lilyjazz FYI: The dashboard-monitoring.md file reuses most content of the Key Metrics on Performance Overview. Only the first 18 lines of this file and the modification in TOC need review.

@shichun-0415 shichun-0415 mentioned this pull request Aug 5, 2022
Merged
13 tasks
ran-huang
ran-huang reviewed Aug 10, 2022
View reviewed changes
dashboard/dashboard-monitoring.md Show resolved Hide resolved
dashboard/dashboard-monitoring.md Outdated Show resolved Hide resolved
dashboard/dashboard-monitoring.md Outdated Show resolved Hide resolved
@shichun-0415 @ran-huang
Apply suggestions from code review
a93025c 
Co-authored-by: Ran <huangran@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 10, 2022
@shichun-0415 shichun-0415 reopened this Aug 10, 2022
@shichun-0415
Copy link
Contributor Author

/verify

3 similar comments
@shichun-0415
Copy link
Contributor Author

/verify

@shichun-0415
Copy link
Contributor Author

/verify

@shichun-0415
Copy link
Contributor Author

/verify

@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 10, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a93025c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2022
@ti-chi-bot ti-chi-bot merged commit 26d4427 into pingcap:master Aug 10, 2022
@shichun-0415 shichun-0415 deleted the add-monitoring-page branch August 10, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyjazz lilyjazz lilyjazz approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shichun-0415 @ti-chi-bot @lilyjazz @ran-huang