This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
support argument "--complete-insert" #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
another question, does dumpling handle generated columns well? |
dumpling will use "complete-insert" mode if there are generated columns in the table. |
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 50.28% 50.28%
=======================================
Files 17 17
Lines 1941 1941
=======================================
Hits 976 976
Misses 892 892
Partials 73 73 |
|
@kennytm @overvenus cloud you take a look for this? |
|
one thing i'm afraid is that this overlaps with the |
Keep |
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
resolve #134
What is changed and how it works?
Add argument
--complete-insertin dumpling.Check List
Tests
Related changes
Release note