Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

fix binary value null value problem #137

Merged
merged 6 commits into from
Aug 21, 2020

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Dumpling doesn't handle null value for binary type variable.

What is changed and how it works?

Handle null value when dumping binary columns.

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Handle null value when dumping binary columns.

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a test case for

create table a(c blob);
insert into a values (x'');
insert into a values (null);

rest LGTM

install.sh Show resolved Hide resolved
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kennytm kennytm added status/LGT1 One reviewer approved (LGTM1) and removed status/PTAL labels Aug 21, 2020
@kennytm kennytm merged commit 361439b into pingcap:master Aug 21, 2020
@lichunzhu lichunzhu deleted the fixBinaryNullValue branch August 21, 2020 03:27
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* fix binary value null value problem

* fix csv

* address comments

* address comments
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* fix binary value null value problem

* fix csv

* address comments

* address comments
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* fix binary value null value problem

* fix csv

* address comments

* address comments
tisonkun pushed a commit to tisonkun/dumpling that referenced this pull request Oct 20, 2021
* fix binary value null value problem

* fix csv

* address comments

* address comments
tisonkun pushed a commit to tisonkun/tidb that referenced this pull request Oct 20, 2021
* fix binary value null value problem

* fix csv

* address comments

* address comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT1 One reviewer approved (LGTM1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants