This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Unify --filesize and --statement-size definition with mydumper's
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kennytm
reviewed
Aug 31, 2020
v4/export/ir.go
Outdated
Comment on lines
30
to
32
| HasNext(currentStatementSize, currentFileSize uint64) bool | ||
| HasNextSQLRowIter(currentFileSize uint64) bool | ||
| AdjustFileRowIterSize(currentStatementSize, currentFileSize uint64) |
There was a problem hiding this comment.
why must these passed as arguments into the iterator?
There was a problem hiding this comment.
Because currently the written size is saved in writer but the FilesizeLimit and StatementsizeLimit is saved in file row iterator
There was a problem hiding this comment.
gotta say this solution doesn't look good to me. the SQLRowIter should only care about pumping out *sql.Rows, it should be the CSVWriter/SQLWriter's responsibility to know when to add the statement separator and when to create a new file.
There was a problem hiding this comment.
I see. I will take thought on how to refine this.
There was a problem hiding this comment.
revised, PTAL again
kennytm
reviewed
Sep 7, 2020
v4/export/writer_util.go
Outdated
Comment on lines
91
to
94
| if b.fileSizeLimit != UnspecifiedSize && b.currentFileSize >= b.fileSizeLimit { | ||
| return true | ||
| } | ||
| return false |
There was a problem hiding this comment.
Suggested change
| if b.fileSizeLimit != UnspecifiedSize && b.currentFileSize >= b.fileSizeLimit { | |
| return true | |
| } | |
| return false | |
| return b.fileSizeLimit != UnspecifiedSize && b.currentFileSize >= b.fileSizeLimit |
v4/export/writer_util.go
Outdated
Comment on lines
98
to
104
| if b.fileSizeLimit != UnspecifiedSize && b.currentFileSize >= b.fileSizeLimit { | ||
| return true | ||
| } | ||
| if b.statementSizeLimit != UnspecifiedSize && b.currentStatementSize >= b.statementSizeLimit { | ||
| return true | ||
| } | ||
| return false |
kennytm
approved these changes
Sep 8, 2020
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…ingcap#142) * reduce bound address times to save more time * tmp * unify file size * fix ut * fix bug that escapeBackSlash not used for rows arguments * tmp * move filesize and statementsize argument to writepipe * fix format * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…ingcap#142) * reduce bound address times to save more time * tmp * unify file size * fix ut * fix bug that escapeBackSlash not used for rows arguments * tmp * move filesize and statementsize argument to writepipe * fix format * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…ingcap#142) * reduce bound address times to save more time * tmp * unify file size * fix ut * fix bug that escapeBackSlash not used for rows arguments * tmp * move filesize and statementsize argument to writepipe * fix format * address comment
tisonkun
pushed a commit
to tisonkun/dumpling
that referenced
this pull request
Oct 20, 2021
…ingcap#142) * reduce bound address times to save more time * tmp * unify file size * fix ut * fix bug that escapeBackSlash not used for rows arguments * tmp * move filesize and statementsize argument to writepipe * fix format * address comment
tisonkun
pushed a commit
to tisonkun/tidb
that referenced
this pull request
Oct 20, 2021
…ingcap/dumpling#142) * reduce bound address times to save more time * tmp * unify file size * fix ut * fix bug that escapeBackSlash not used for rows arguments * tmp * move filesize and statementsize argument to writepipe * fix format * address comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #127
What is changed and how it works?
Don't only count data for
statement-sizeandfilesizeoptions.Check List
Tests
Related changes
Release note
unify
--filesizeand--statement-sizedefinition with mydumper's