Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go-diff for support Golang 1.16 #63

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

blacktear23
Copy link
Contributor

What problem does this PR solve?

After upgrade golang to 1.16 at TiDB make test will got error messages:

../../../../pkg/mod/github.com/pingcap/failpoint@v0.0.0-20200702092429-9f69995143ce/code/restorer.go:24:2: missing go.sum entry for module providing package github.com/sergi/go-diff/diffmatchpatch (imported by github.com/pingcap/failpoint/code); to add:
	go get github.com/pingcap/failpoint/code@v0.0.0-20200702092429-9f69995143ce

What is changed and how it works?

Upgrade go-diff to v1.1.0 will solve this problem.

Check List

Tests

  • No Code

Side effects

  • Not sure yet, but tests are passed

Related changes

  • Need to upgrade go.mod at TiDB and other use failpoint projects

@kennytm
Copy link
Contributor

kennytm commented Mar 15, 2021

Lgtm

@bb7133
Copy link
Member

bb7133 commented Mar 15, 2021

lgtm

@bb7133
Copy link
Member

bb7133 commented Mar 15, 2021

PTAL @lonng

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2021

CLA assistant check
All committers have signed the CLA.

@lonng lonng merged commit 7acb0f0 into pingcap:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants