Upgrade gRPC to v1.14.2 #203

overvenus · 2018-07-06T17:39:35Z

This PR upgrades the gRPC to v1.10.0, replaces core alarm with grpc++'s. Its ABI is compatible with the offical grpc.

Please do not merge this until tikv/grpc#12 gets merged.

TODO:

Fix macOS build.
Fix Windows build.
Fix timeout_on_sleeping_server

siddontang · 2018-07-09T01:49:53Z

grpc-sys/build.rs

        cc.define("GRPC_SYS_SECURE", None);
-        "grpc"
+        ("grpc", "grpc++")


The latest gRPC use grpcpp and may deprecate grpc++, we need to add comments here and don't forget to change it later.

Btw, maybe we can upgrade to the gRPC 1.13 directly.

Dont worry, it's the name grpc++ library, it is not changed in the gRFC L22 .
It only changes the include path grpcpp/....

yes, but I think we should use grpcpp, it is recommended officially.

grpcpp is a include path. grpc++ is the name of cpp library, it's still grpc++, and there is no library called grpcpp.
See it's Cmakefile https://github.com/grpc/grpc/blob/v1.13.0/CMakeLists.txt#L2689
and Makefile https://github.com/grpc/grpc/blob/v1.13.0/Makefile#L1380

if you use C++ gRPC, you can find that the generated files and examples now all use cpp header.

https://github.com/grpc/grpc/blob/master/examples/cpp/route_guide/route_guide_client.cc#L28

siddontang · 2018-07-09T01:53:27Z

grpc-sys/grpc_wrap.cc

+/** Create a completion queue alarm instance */
+GPR_EXPORT grpcwrap_alarm *GPR_CALLTYPE
+grpcwrap_alarm_create(void) {
+  void *ptr = gpr_malloc(sizeof(Alarm));


em, seem you can malloc with sizeof(Alarm) + sizeof(grpcwrap_alarm) for both Alarm and wapper, so we don't need to alloc and dealloc twice.

siddontang · 2018-07-09T01:58:10Z

This PR is awesome, coooooooooool!

BusyJay

@huachaohuang PTAL

BusyJay · 2018-07-09T08:20:28Z

.travis.yml

  - cargo build --no-default-features
  - cargo build --no-default-features --features protobuf-codec
  - cargo build
  - cargo test --all
-  - GRPCIO_SYS_USE_PKG_CONFIG=1 cargo test --all
+  - GRPCIO_SYS_USE_PKG_CONFIG=1 cargo build --all


I have trouble in linking grpcio's test targets, need help. 🆘

Can you give some more information?

From: https://travis-ci.org/overvenus/grpc-rs/jobs/400903660

Compiling grpcio-sys v0.2.3 (file:///home/travis/build/overvenus/grpc-rs/grpc-sys) Compiling grpcio v0.3.0 (file:///home/travis/build/overvenus/grpc-rs) error: linking with `cc` failed: exit code: 1 | = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.1v9koybaboeosxiy.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.1y16o1qfye96o7m0.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.2rnarwe9869ff3em.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.2xs38k3nu4oe9uo6.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.3rngp6bm2u2q5z0y.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.4oc10dk278mpk1vy.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.4xq48u46a1pwiqn7.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.51s1w397y42gpez1.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.5et8vp13oj1m4v7a.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.8xzrsc1ux72v29j.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.9elsx31vb4it187.rcgu.o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.oa3rad818d8sgn4.rcgu.o" "-o" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/grpcio_sys-6001af5e1c5efae1.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/home/travis/build/overvenus/grpc-rs/target/debug/deps" "-L" "/home/travis/.cache/lib" "-L" "/home/travis/.cache/lib" "-L" "/home/travis/build/overvenus/grpc-rs/target/debug/build/grpcio-sys-afd36be57b22e64e/out" "-L" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "grpc" "-l" "grpc++" "-Wl,-Bstatic" "-Wl,--whole-archive" "-l" "grpc_wrap" "-Wl,--no-whole-archive" "-Wl,-Bdynamic" "-l" "stdc++" "-Wl,-Bstatic" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libtest-315d48fd46f254fe.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libterm-4dd46751eaaa3cb4.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgetopts-b0cb061f9f47a202.rlib" "/home/travis/build/overvenus/grpc-rs/target/debug/deps/liblibc-76755a6888618a72.rlib" "-Wl,--start-group" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-2e0e6fd5a64772ec.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-731e169e757c346a.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-095fc2295ae9ef1b.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-937988d834c61738.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_system-b7ac4cdefbcbe74e.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-2acd14cf338f9037.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-abc00040df319771.rlib" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-c03be6943b237af4.rlib" "-Wl,--end-group" "/home/travis/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-7d0cd09e2c099c63.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" = note: /home/travis/build/overvenus/grpc-rs/target/debug/build/grpcio-sys-afd36be57b22e64e/out/libgrpc_wrap.a(grpc_wrap.o):(.data.rel._ZN4grpc8internalL14g_core_codegenE+0x0): undefined reference to `vtable for grpc::CoreCodegen' /home/travis/build/overvenus/grpc-rs/target/debug/build/grpcio-sys-afd36be57b22e64e/out/libgrpc_wrap.a(grpc_wrap.o): In function `grpc::CoreCodegen::~CoreCodegen()': /home/travis/.cache/include/grpcpp/impl/codegen/core_codegen.h:32: undefined reference to `vtable for grpc::CoreCodegen' collect2: error: ld returned 1 exit status

It may be related to grpc/grpc#13500

Yes I see the same error:

Compiling clap v2.31.2 Compiling grpcio-sys v0.2.3 (file:///home/hoverbear/git/grpc-rs/grpc-sys) Compiling grpcio-compiler v0.3.0 (file:///home/hoverbear/git/grpc-rs/compiler) Compiling grpcio v0.3.0 (file:///home/hoverbear/git/grpc-rs) Compiling grpcio-proto v0.3.0 (file:///home/hoverbear/git/grpc-rs/proto) error: linking with `cc` failed: exit code: 1 | = note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.1v9koybaboeosxiy.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.1y16o1qfye96o7m0.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.2rnarwe9869ff3em.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.2xs38k3nu4oe9uo6.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.3rngp6bm2u2q5z0y.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.4oc10dk278mpk1vy.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.4xq48u46a1pwiqn7.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.51s1w397y42gpez1.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.5et8vp13oj1m4v7a.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.8xzrsc1ux72v29j.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.9elsx31vb4it187.rcgu.o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.oa3rad818d8sgn4.rcgu.o" "-o" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03" "/home/hoverbear/git/grpc-rs/target/debug/deps/grpcio_sys-04563ee405ba0b03.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-nodefaultlibs" "-L" "/home/hoverbear/git/grpc-rs/target/debug/deps" "-L" "/usr/lib" "-L" "/usr/lib" "-L" "/home/hoverbear/git/grpc-rs/target/debug/build/grpcio-sys-ac23585aa46eac93/out" "-L" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib" "-l" "grpc" "-l" "grpc++" "-Wl,-Bstatic" "-Wl,--whole-archive" "-l" "grpc_wrap" "-Wl,--no-whole-archive" "-Wl,-Bdynamic" "-l" "stdc++" "-Wl,-Bstatic" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libtest-019326da6686230a.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libterm-7f8a78dfff7bac57.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgetopts-dbfbcb47517df890.rlib" "/home/hoverbear/git/grpc-rs/target/debug/deps/liblibc-77d5831ef1267f52.rlib" "-Wl,--start-group" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libstd-0888da25bc5aa659.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libpanic_unwind-c21a3f7e9b2ce71d.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_jemalloc-a89ec74248f6f925.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libunwind-9232e45013d81e94.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc_system-afbe0a28ca4ea99f.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liblibc-bcf95ff3aa4e3276.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/liballoc-26716181a02171e3.rlib" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcore-978afee7e21437ec.rlib" "-Wl,--end-group" "/home/hoverbear/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-gnu/lib/libcompiler_builtins-3f4ad009a7cf735f.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "util" "-l" "dl" "-l" "rt" "-l" "pthread" "-l" "pthread" "-l" "gcc_s" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "util" "-l" "util" = note: /home/hoverbear/git/grpc-rs/target/debug/build/grpcio-sys-ac23585aa46eac93/out/libgrpc_wrap.a(grpc_wrap.o):(.data.rel._ZN4grpc8internalL14g_core_codegenE+0x0): undefined reference to `vtable for grpc::CoreCodegen' /home/hoverbear/git/grpc-rs/target/debug/build/grpcio-sys-ac23585aa46eac93/out/libgrpc_wrap.a(grpc_wrap.o): In function `grpc::CoreCodegen::~CoreCodegen()': /usr/include/grpcpp/impl/codegen/core_codegen.h:32: undefined reference to `vtable for grpc::CoreCodegen' collect2: error: ld returned 1 exit status

do we need to wait for the official team fixing it or just work around it? @overvenus

It have been fixed in e2639c3.

siddontang · 2018-07-10T01:12:28Z

do you use https://github.com/grpc/grpc/blob/master/.clang-format to format the CPP codes?

overvenus · 2018-07-11T07:29:23Z

PTAL @siddontang #206 .

huachaohuang · 2018-07-11T08:16:11Z

I may need some time to scan the gRPC code before I can review this PR.

Hoverbear · 2018-07-13T20:00:43Z

benches/calltag.rs

+    /// Consumes the `MockTag`, returning the wrapped raw pointer.
+    pub fn into_raw(self) -> *mut GrpcwrapTag {
+        if let MockTag::Spawn(_) = self {
+            panic!("MockTag::Spawn can not into raw pointer")


can not turn into a raw pointer

Hoverbear · 2018-07-13T20:25:12Z

grpc-sys/grpc_wrap.cc

+  CompletionQueue* cq;
+} grpcwrap_completion_queue;
+
+/** Create a ComletionQueue, a shadow of grpc_completion_queue.


CompletionQueue

Hoverbear · 2018-07-13T20:27:13Z

grpc-sys/grpc_wrap.cc

+/** Set a completion queue alarm instance associated to a cq.
+ *
+ * Once the alarm notifies (see a grpcwrap_alarm_notify) or it's destroy (see a
+ * grpcwrap_alarm_destroy), an event with tag a tag will be added to a cq. If the


You repeat yourself here an event with tag a tag

Hoverbear · 2018-07-13T20:34:04Z

grpc-sys/grpc_wrap.cc

+
+/** Set a completion queue alarm instance associated to a cq.
+ *
+ * Once the alarm notifies (see a grpcwrap_alarm_notify) or it's destroy (see a


You mention grpcwrap_alarm_notify but I do not see anything called this. Can you help me find it?

hoverbear@nomad:git/grpc-rs ‹upgrade-1.10-1*›$ rg grpcwrap_alarm_notify grpc-sys/grpc_wrap.cc 888: * Once the alarm notifies (see a grpcwrap_alarm_notify) or it's destroy (see a

Hm, it should be grpcwrap_alarm_cancel. 🤦‍♂️

Hoverbear · 2018-07-13T20:36:58Z

grpc-sys/grpc_wrap.cc

+/** A helper class that implements `CompletionQueueTag`.
+ *
+ * TODO: Remove it. The `grpc::Alarm` submit itself as a tag to a
+ * `CompletionQueue`, so we needs it to unify extraction of tags`.


we need it

overvenus · 2018-07-14T05:07:00Z

@huachaohuang
You may interest in how a grpc CompletionQueue interacts with(put/get) tags,
Get: https://github.com/grpc/grpc/blob/v1.13.0/src/cpp/common/completion_queue_cc.cc#L62-L69
Put: https://github.com/grpc/grpc/blob/v1.13.0/src/cpp/common/alarm.cc#L60-L73

Hoverbear · 2018-07-16T18:22:48Z

src/cq.rs

@@ -110,6 +117,7 @@ impl CompletionQueueHandle {
 impl Drop for CompletionQueueHandle {
    fn drop(&mut self) {
        unsafe { grpc_sys::grpc_completion_queue_destroy(self.cq) }
+        // TOOD: free cq_shadow.


I think it would be good to address this before merging so we don't have a memory leak.

siddontang · 2018-09-10T09:36:07Z

interop/src/server.rs

@@ -133,6 +135,14 @@ impl TestService for InteropTestService {
                    if let Some(param) = req.get_response_parameters().get(0) {
                        resp.set_payload(util::new_payload(param.get_size() as usize));
                    }
+                    // A Workaround for timeout_on_sleeping_server test.
+                    // The request only has 27182 bytes of zeros in payload.
+                    if req.get_payload().get_body().len() == 27182


oh, 27182 is so magic 😭

siddontang · 2018-09-10T09:36:27Z

seem we need to upgrade the Cargo version now.

siddontang

LGTM

BusyJay · 2018-09-11T09:33:56Z

.travis.yml

@@ -8,6 +8,7 @@ cache:
    - $TRAVIS_BUILD_DIR/target
 before_cache:
  - find $TRAVIS_BUILD_DIR/target/debug -maxdepth 1 -type f -delete
+  - cargo clean -p grpcio-sys


BusyJay · 2018-09-11T09:35:36Z

.travis.yml

+    fi
+  - >-
+    if [[ ! -f "$GRPC_HEADER" ]] ; then
+      (


BusyJay · 2018-09-11T09:37:05Z

.travis.yml

+        git clone -b v$GRPC_VERSION https://github.com/grpc/grpc &&
+        cd grpc &&
+        git submodule update --init &&
+        env prefix=$HOME/.cache make install_c install_cxx &&


Is cxx still necessary?

BusyJay · 2018-09-11T09:37:31Z

.travis.yml

  - export PATH="$PATH:$HOME/.cache/bin:$HOME/.cargo/bin"
  - GRPC_HEADER="$HOME/.cache/include/grpc/grpc.h"
-  - if [[ $TRAVIS_OS_NAME == "osx" ]] && [[ ! -f $GRPC_HEADER ]]; then export CC=clang; brew update && brew install autoconf libtool shtool; fi
-  - test -f "$GRPC_HEADER" || (git clone -b v1.7.2 https://github.com/grpc/grpc && cd grpc && git submodule update --init && env prefix=$HOME/.cache make install_c)
+  - >-


I don't think >- is necessary if if is moved up.

BusyJay · 2018-09-11T09:44:28Z

src/cq.rs

@@ -109,7 +109,9 @@ impl CompletionQueueHandle {

 impl Drop for CompletionQueueHandle {
    fn drop(&mut self) {
-        unsafe { grpc_sys::grpc_completion_queue_destroy(self.cq) }
+        unsafe {
+            grpc_sys::grpc_completion_queue_destroy(self.cq);


Why change?

BusyJay · 2018-09-12T05:49:33Z

grpc-sys/build.rs

+
+    if use_pkg_config {
+        // Link libgrpc.so.
+        probe_library(library, true);


Is it still necessary to probe the library twice?

BusyJay · 2018-09-12T05:51:30Z

interop/src/server.rs

@@ -133,6 +135,14 @@ impl TestService for InteropTestService {
                    if let Some(param) = req.get_response_parameters().get(0) {
                        resp.set_payload(util::new_payload(param.get_size() as usize));
                    }
+                    // A Workaround for timeout_on_sleeping_server test.
+                    // The request only has 27182 bytes of zeros in payload.


Is it still necessary?

Why? You have set timeout to 1ms already at https://github.com/pingcap/grpc-rs/pull/203/files#diff-ef1f1e350c60784b68130f3cd88fbef6R170

You can set it to 1ms, and you will find the client may receive a response.

This is too hacky. And comment should talk about the problem this hack tries to work around.

A friendly ping.

overvenus · 2018-09-13T03:45:33Z

PTAL, thanks!

overvenus · 2018-09-14T07:48:37Z

A friendly ping.

siddontang

LGTM

siddontang · 2018-09-14T17:39:33Z

@overvenus

please update the Cargo version

siddontang reviewed Jul 9, 2018

View reviewed changes

BusyJay reviewed Jul 9, 2018

View reviewed changes

overvenus changed the title ~~Upgrade gRPC to v1.10.0, take 2~~ Upgrade gRPC to v1.13.0, take 2 Jul 9, 2018

Hoverbear reviewed Jul 13, 2018

View reviewed changes

overvenus added 8 commits July 14, 2018 13:21

Upgrade grpc-sys

0540794

*: upgrade to gRPC 1.10.0

45f9513

benches: add a tag benchmark

eba8dd5

Upgrade grpc to 1.10.0

af4a6ea

Address comments

5224845

Upgrade to 1.13.0

324e0cb

Address comments

91fc651

Fix linking grpc and grpc++

e2639c3

overvenus force-pushed the upgrade-1.10-1 branch from b1853cd to e2639c3 Compare July 14, 2018 08:59

Hoverbear reviewed Jul 16, 2018

View reviewed changes

A. Hobden and others added 5 commits July 16, 2018 17:50

Merge branch 'master' into upgrade-1.10-1

3581c07

clang-format!

0cd2524

Suppress warning C4530 from include\xlocale

4f2a224

Free cq_shadow

3b1dac9

Fix macos build

0381bc9

overvenus force-pushed the upgrade-1.10-1 branch from ff9d60f to 0381bc9 Compare July 17, 2018 16:48

BusyJay mentioned this pull request Sep 6, 2018

Is there a way to detect a closed connection between sending stuff to the sink #175

Closed

overvenus added 2 commits September 6, 2018 21:43

Merge branch 'master' into upgrade-1.10-1

b77c914

Remove alarm

f9922c9

overvenus force-pushed the upgrade-1.10-1 branch from 63fee4f to f9922c9 Compare September 6, 2018 14:06

Upgrade to v1.14.2

9e8a1bd

overvenus changed the title ~~Upgrade gRPC to v1.13.0, take 2~~ Upgrade gRPC to v1.14.2 Sep 10, 2018

Merge branch 'master' into upgrade-1.10-1

e977199

siddontang reviewed Sep 10, 2018

View reviewed changes

siddontang previously approved these changes Sep 11, 2018

View reviewed changes

BusyJay reviewed Sep 11, 2018

View reviewed changes

overvenus dismissed siddontang’s stale review via bce6663 September 12, 2018 05:03

overvenus force-pushed the upgrade-1.10-1 branch from bce6663 to 1a5ff44 Compare September 12, 2018 05:10

Clean up

894aeb1

overvenus force-pushed the upgrade-1.10-1 branch from 1a5ff44 to 894aeb1 Compare September 12, 2018 05:14

BusyJay reviewed Sep 12, 2018

View reviewed changes

Address comments

4262564

Address comment

448d191

BusyJay previously approved these changes Sep 14, 2018

View reviewed changes

Update grpc

327e524

overvenus dismissed BusyJay’s stale review via 327e524 September 14, 2018 12:20

siddontang approved these changes Sep 14, 2018

View reviewed changes

overvenus merged commit b47f32f into master Sep 14, 2018

overvenus deleted the upgrade-1.10-1 branch September 14, 2018 13:46

bacek pushed a commit to bacek/grpc-rs that referenced this pull request Oct 9, 2018

Upgrade gRPC to v1.14.2 (tikv#203)

1a2f040

ice1000 mentioned this pull request Oct 10, 2018

Use actual gRPC library #197

Closed

ice1000 added the gRPC Core Related to grpc's c/cpp core label Dec 24, 2018

Upgrade gRPC to v1.14.2 #203

Upgrade gRPC to v1.14.2 #203

Conversation

overvenus commented Jul 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siddontang commented Jul 9, 2018

BusyJay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siddontang commented Jul 10, 2018

overvenus commented Jul 11, 2018

huachaohuang commented Jul 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

overvenus commented Jul 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

siddontang commented Sep 10, 2018

siddontang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

overvenus commented Sep 13, 2018

overvenus commented Sep 14, 2018

siddontang left a comment

Choose a reason for hiding this comment

siddontang commented Sep 14, 2018

overvenus commented Jul 6, 2018 •

edited

Loading

overvenus commented Jul 14, 2018 •

edited

Loading