Define the independent (Tenant) TSO gRPC server #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Issue Number: ref #5836 |
|
Hi @binshi-bing , you will have to sign the CLA before we can merge your PR. |
lhy1024
reviewed
Feb 6, 2023
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
from
12ab52f
to
22ec660
Compare
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
from
22ec660
to
d88db97
Compare
binshi-bing
changed the title
binshi-bing
commented
Feb 8, 2023
proto/tsopb.proto
Outdated
|
|
||
| message RequestHeader { | ||
| // tenant_id is the unique id of the tenant | ||
| TenantID tenant_id = 1; |
There was a problem hiding this comment.
Thought about setting it to optional, but decided not to do so. Let me know if you have different options.
rleungx
reviewed
Feb 8, 2023
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
from
6af5a98
to
efdbe41
Compare
binshi-bing
changed the title
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
2 times, most recently
from
d62dad4
to
d4c6f18
Compare
binshi-bing
added a commit
to binshi-bing/pd
that referenced
this pull request
Feb 12, 2023
Basic implement the indepent (Tenant) TSO gPRC service. The kvproto pr is here pingcap/kvproto#1053 Signed-off-by: Bin Shi <binshi.bing@gmail.com>
binshi-bing
added a commit
to binshi-bing/pd
that referenced
this pull request
Feb 13, 2023
Basic implement the indepent (Tenant) TSO gPRC service. The kvproto pr is here pingcap/kvproto#1053 Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Issue Number: ref #5836 Signed-off-by: binshi-bing <binshi.bing@gmail.com>
Signed-off-by: Bin Shi <binshi.bing@gmail.com>
…back-compatability Signed-off-by: Bin Shi <binshi.bing@gmail.com>
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
from
d4c6f18
to
f67a08b
Compare
revert to option 1 mentioned in https://pingcap.feishu.cn/docx/K1kMdZaUmoeV7fxCH4jclmmtnTc for the following two reasons: 1. We mightn't want to support multi-tenant in the existing pdpb rpcs and messages. 2. No need to do the refactor mentioned in option 2 for now, as it isn't clear for how to refactor the tso related data structures and logic in the pkg/tso. 3. Minimize the change and refactor in server/grpc_server to avoid introducing bugs into PD path. Signed-off-by: Bin Shi <binshi.bing@gmail.com>
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
from
f67a08b
to
57c74a8
Compare
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
from
e4a452a
to
174f4d4
Compare
… on tso data structures which use pdpb message type directly and need more refactor. Signed-off-by: Bin Shi <binshi.bing@gmail.com>
binshi-bing
force-pushed
the
add-new-tso-service-in-protobuf
branch
from
174f4d4
to
990822e
Compare
rleungx
approved these changes
Feb 16, 2023
lhy1024
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: ref #5836
Signed-off-by: binshi-bing binshi.bing@gmail.com
Changes: