Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support return TiFlash system table by grpc #1094

Merged

Conversation

Lloyd-Pottiger
Copy link
Contributor

Signed-off-by: Lloyd-Pottiger yan1579196623@gmail.com

@disksing
Copy link
Contributor

generally LGTM. Is it ready to merge or need someone else to review?

@Lloyd-Pottiger
Copy link
Contributor Author

generally LGTM. Is it ready to merge or need someone else to review?

thank you, but wait for a while, it may still need make some changes.

@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as draft March 29, 2023 07:38
@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as ready for review March 30, 2023 09:31
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Copy link

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lloyd-Pottiger Lloyd-Pottiger merged commit e166ae5 into pingcap:master Apr 3, 2023
@Lloyd-Pottiger Lloyd-Pottiger deleted the return-system-table-by-grpc branch April 3, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants