Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(proto): fix misspell approver SIGs #1241

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore(proto): fix misspell approver SIGs #1241

merged 1 commit into from
Apr 12, 2024

Conversation

wuhuizuo
Copy link
Contributor

No description provided.

@ti-chi-bot ti-chi-bot bot added the size/XS label Apr 12, 2024
ti-chi-bot
ti-chi-bot approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@ti-chi-bot ti-chi-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatic LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

@ti-chi-bot: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

automatic LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

/cc @tonyxuqqi

@ti-chi-bot ti-chi-bot bot requested a review from tonyxuqqi April 12, 2024 08:19
@wuhuizuo
Copy link
Contributor Author

/hold

@wuhuizuo wuhuizuo closed this Apr 12, 2024
@wuhuizuo wuhuizuo reopened this Apr 12, 2024
@wuhuizuo
Copy link
Contributor Author

/hold

@wuhuizuo
Copy link
Contributor Author

/unhold

@wuhuizuo wuhuizuo marked this pull request as draft April 12, 2024 13:48
@wuhuizuo wuhuizuo marked this pull request as ready for review April 12, 2024 13:50
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

@tonyxuqqi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tonyxuqqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit f3c1264 into master Apr 12, 2024
8 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/owners-file branch April 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@ti-chi-bot ti-chi-bot ti-chi-bot approved these changes

Assignees
No one assigned
Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wuhuizuo @ti-chi-bot @tonyxuqqi