debugpb: rename some fields #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BusyJay
reviewed
Sep 20, 2017
proto/debugpb.proto
Outdated
| bytes key_encoded = 2; | ||
| // An arbitrary key for retrieving value from TiKV. | ||
| // Note: Server uses it directly w/o any encoding. | ||
| bytes key = 2; |
There was a problem hiding this comment.
I think a db field is necessary.
BusyJay
reviewed
Sep 20, 2017
proto/debugpb.proto
Outdated
| @@ -51,7 +51,9 @@ enum CF { | |||
|
|
|||
| message GetRequest { | |||
| CF cf = 1; | |||
There was a problem hiding this comment.
Use string is more flexible.
- Replace CF with string - Remove enum CF - Add enum DB - More detailed size response
BusyJay
reviewed
Sep 20, 2017
proto/debugpb.proto
Outdated
| // An arbitrary key for retrieving value from TiKV. | ||
| // Note: Server uses it directly w/o any encoding. | ||
| bytes key = 2; | ||
| bytes key = 1; |
There was a problem hiding this comment.
Please keep it in the order db, cf then key.
|
LGTM |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC tikv/tikv#2299