backup: add GCS proto #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SunRunAway
requested review from
tennix,
overvenus,
DanielZhangQD and
kennytm
proto/backup.proto
Outdated
| // } | ||
| // } | ||
| // ]` | ||
| string acl_json = 5; |
There was a problem hiding this comment.
This is object ACL, right?
There was a problem hiding this comment.
Updated, with comments.
tennix
reviewed
Dec 10, 2019
proto/backup.proto
Outdated
| string bucket = 2; | ||
| string prefix = 3; | ||
| string storage_class = 4; | ||
| // acl json: like `[ |
There was a problem hiding this comment.
I think this is a serialized json string. It doesn't have to be the format below. So I suggest modifying the comment. And also it's better to add a documentation link to these two fields since many people not knowing this.
9 tasks
SunRunAway
added a commit
to SunRunAway/kvproto
that referenced
this pull request
Dec 12, 2019
kennytm
pushed a commit
that referenced
this pull request
Dec 12, 2019
daimashusheng
pushed a commit
to daimashusheng/kvproto
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of pingcap/br#89
GCS Support (1800 points)
Extend backup protobuf to support GCS