Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement test logger #16

Merged
merged 10 commits into from
Jun 25, 2021
Merged

implement test logger #16

merged 10 commits into from
Jun 25, 2021

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jun 24, 2021 •
edited
Loading

Previous discussion at https://internals.tidb.io/t/topic/48

  1. Remove remove redundant private newZapTextEncoder
  2. Refactor a bit log.go for sane.
  3. Port zaptest's testingWriter to InitTestLogger
  4. Update test to use our new test logger.

@tisonkun
remove redundant private newZapTextEncoder
155af94 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
refactor log
1e015fd 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
implement InitTestLogger
32fd260 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
test: update to new test logger
f2806af 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
mod: go mod tidy
506bc6f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
docs: README
e9b921a 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun requested review from nolouch and lysu June 24, 2021 10:57
@tisonkun
ci: github actions
c448ea2 
Signed-off-by: tison <wander4096@gmail.com>
@lysu
Copy link
Collaborator

lysu commented Jun 25, 2021

LGTM..it's no problem to me :)

nolouch
nolouch approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nolouch nolouch merged commit 98ed8e2 into pingcap:master Jun 25, 2021
@tisonkun
Copy link
Contributor Author

Thanks for your review and merging!

@tisonkun tisonkun deleted the testlog branch July 12, 2021 12:31
@tisonkun tisonkun mentioned this pull request Jul 12, 2021
Closed
@tisonkun tisonkun mentioned this pull request Jul 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tisonkun @lysu @nolouch