Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --replace_regex #112

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Support --replace_regex #112

merged 5 commits into from
Nov 14, 2023

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 14, 2023 •
edited
Loading

ref #110

You could read the example via t/example.test

ref link from mysql
https://github.com/search?q=repo%3Amysql%2Fmysql-server%20--replace_regex&type=code

@Defined2014 Defined2014 changed the title Support replace regex Support --replace_regex Nov 14, 2023
@Defined2014
Copy link
Contributor Author

@tiancaiamao @bb7133
PTAL

@Defined2014 Defined2014 mentioned this pull request Nov 14, 2023
Open
9 tasks
mjonss
mjonss approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to document that the replace_regex command has a different regex engine than MySQL's mysqltester?

@bb7133 bb7133 merged commit 6fe2160 into pingcap:master Nov 14, 2023
1 check passed
@Defined2014
Copy link
Contributor Author

LGTM. Do we need to document that the replace_regex command has a different regex engine than MySQL's mysqltester?

Good suggestion, I will add this todo in #110

@Defined2014 Defined2014 mentioned this pull request Nov 15, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Defined2014 @tiancaiamao @mjonss @bb7133