lexer: Format syntax errmsg when value out of range #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
can you please add some test? |
erwadba
force-pushed
the
formatsyntaxerrmsg
branch
from
acc3b9a
to
d6dab16
Compare
|
When I add test about decimal value in parser_test.go. like below The test will be failed. Maybe I should add some test in tidb about decimal value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
related PR: pingcap/tidb#17489 pingcap/tidb#17745
What is changed and how it works?
Add AppendWarn func in lexer.go.
Generate a warning when decimal value out of range. And return the default value.
Check List
Tests
Code changes
Side effects
Related changes
-N/A