Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorcode: add error code from tablecodec, structure, admin tidb file #678

Merged
merged 2 commits into from Dec 16, 2019

Conversation

cfzjywxk
Copy link
Contributor

What problem does this PR solve?

Add left error codes

errInvalidHashKeyFlag = terror.ClassStructure.New(codeInvalidHashKeyFlag, "invalid encoded hash key flag")
errInvalidListIndex = terror.ClassStructure.New(codeInvalidListMetaData, "invalid list index")
errInvalidListMetaData = terror.ClassStructure.New(codeInvalidListMetaData, "invalid list meta data")
errWriteOnSnapshot = terror.ClassStructure.New(codeWriteOnSnapshot, "write on snapshot")
errInvalidKey = terror.ClassXEval.New(codeInvalidKey, "invalid key")
errInvalidRecordKey = terror.ClassXEval.New(codeInvalidRecordKey, "invalid record key")
errInvalidIndexKey = terror.ClassXEval.New(codeInvalidIndexKey, "invalid index key")
ErrDataInConsistent = terror.ClassAdmin.New(codeDataNotEqual, "data isn't equal")
ErrDDLJobNotFound = terror.ClassAdmin.New(codeDDLJobNotFound, "DDL Job:%v not found")
ErrCancelFinishedDDLJob = terror.ClassAdmin.New(codeCancelFinishedJob, "This job:%v is finished, so can't be cancelled")
ErrCannotCancelDDLJob = terror.ClassAdmin.New(codeCannotCancelDDLJob, "This job:%v is almost finished, can't be cancelled now")
ErrUnsupportedType = terror.ClassOptimizer.New(CodeUnsupportedType, "Unsupported type")

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cfzjywxk
Copy link
Contributor Author

/merge

@sre-bot
Copy link

sre-bot commented Dec 14, 2019

/run-all-tests

1 similar comment
@kennytm
Copy link
Contributor

kennytm commented Dec 14, 2019

/run-all-tests

@tangenta
Copy link
Contributor

Reopen PR to rerun CI

@tangenta tangenta closed this Dec 14, 2019
@tangenta tangenta reopened this Dec 14, 2019
@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #678 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   80.12%   80.13%   +<.01%     
==========================================
  Files          33       33              
  Lines       13009    13001       -8     
==========================================
- Hits        10424    10418       -6     
+ Misses       1965     1964       -1     
+ Partials      620      619       -1
Impacted Files Coverage Δ
parser.go 93.15% <0%> (-0.01%) ⬇️
ast/dml.go 74% <0%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7320ce0...1d7a5d3. Read the comment docs.

@tangenta
Copy link
Contributor

/rebuild

@jackysp jackysp merged commit 53ef012 into pingcap:master Dec 16, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants