parser: set UnionStmt and ShowStmt as readonly
#755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
=======================================
Coverage 77.85% 77.85%
=======================================
Files 40 40
Lines 14455 14455
=======================================
Hits 11254 11254
Misses 2516 2516
Partials 685 685 |
|
But what about |
Great catch! |
|
LGTM |
kennytm
approved these changes
Mar 1, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Mar 1, 2020
* add UnionStmt and ShowStmt as readonly * fix UnionStmt
|
/run-cherry-picker |
|
cherry pick to release-3.0 failed |
djshow832
added a commit
to djshow832/parser
that referenced
this pull request
Mar 1, 2020
* add UnionStmt and ShowStmt as readonly * fix UnionStmt
kennytm
pushed a commit
that referenced
this pull request
Mar 1, 2020
* add UnionStmt and ShowStmt as readonly * fix UnionStmt
This was referenced Mar 2, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
* add UnionStmt and ShowStmt as readonly * fix UnionStmt
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
* add UnionStmt and ShowStmt as readonly * fix UnionStmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix pingcap/tidb#15050.
UNIONstatement andSHOWstatement are not treated as readonly statement. These statements are executed again in retrying transactions.What is changed and how it works?
Set
UnionStmtandShowStmtas readonly.Check List
Tests
Code changes
Side effects
N/A
Related changes
Release Note
UNIONstatement andSHOWstatement as readonly statements.