pd-ctl: return full region information for /region api #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any need to add/update test cases? |
|
The title should follow the rule mentioned in the development document https://github.com/pingcap/pd/blob/master/CONTRIBUTING.md#format-of-the-commit-message |
liukun4515
changed the title
|
No test case should be updated. |
disksing
reviewed
Sep 25, 2018
server/api/region_test.go
Outdated
| newTestRegionInfo(3, 1, []byte("b"), []byte("c")), | ||
| newTestRegionInfo(4, 2, []byte("c"), []byte("d")), | ||
| } | ||
| regions := make([]*regionInfo, 0) |
There was a problem hiding this comment.
make([]*regionInfo, 0, len(rs))
disksing
approved these changes
Sep 25, 2018
nolouch
added
the
needs-cherry-pick-release-2.0
disksing
removed
the
needs-cherry-pick-release-2.0
sre-bot
added
the
contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #1223
What is changed and how it works?
Check List
Tests
Side effects
no
Related changes