-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add a log when getting timestamps are too slow (#1863) #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
sre-bot
added
status/can-merge
Indicates a PR has been approved by a committer.
cherry-pick
labels
Oct 30, 2019
lhy1024
approved these changes
Oct 30, 2019
/run-all-tests |
disksing
approved these changes
Oct 30, 2019
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
Your auto merge job has been accepted, waiting for 1868 |
/run-all-tests |
@sre-bot merge failed. |
/run-integration-common-test tidb-test=pr/934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1863 to release-3.0
What problem does this PR solve?
To make clear about whether the server is slow or the network is slow when getting timestamps.
What is changed and how it works?
This PR will print a log when the cost time of getting timestamps is more than 5 Millisecond.
Check List
Tests
Related changes