Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(label): tolerate backslash in the label name (#1595) #2084

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jan 7, 2020

cherry-pick #1595 to release-3.1


Signed-off-by: Shafreeck Sea shafreeck@gmail.com

Closes #1588

What problem does this PR solve?

tolerate backslash in the label name.

What is changed and how it works?

relax the rules to check the validation of a label.

Check List

Tests

  • Unit test

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

Closes tikv#1588
Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>
@sre-bot sre-bot added component/schedule Scheduling logic. cherry-pick type/enhancement The issue belongs to an enhancement. labels Jan 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #2084 into release-3.1 will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.1    #2084     +/-   ##
==============================================
- Coverage        69.63%   69.53%   -0.1%     
==============================================
  Files              171      171             
  Lines            16848    16848             
==============================================
- Hits             11732    11716     -16     
- Misses            4144     4157     +13     
- Partials           972      975      +3
Impacted Files Coverage Δ
server/util.go 72.61% <ø> (+1.91%) ⬆️
pkg/testutil/operator_check.go 83.33% <0%> (-16.67%) ⬇️
pkg/etcdutil/etcdutil.go 79.06% <0%> (-16.28%) ⬇️
server/schedulers/random_merge.go 62.5% <0%> (-5%) ⬇️
server/region_syncer/client.go 81.57% <0%> (-3.95%) ⬇️
server/schedule/operator.go 86.93% <0%> (-0.65%) ⬇️
server/cluster.go 81.31% <0%> (-0.51%) ⬇️
server/grpc_service.go 59.91% <0%> (-0.22%) ⬇️
client/client.go 74.74% <0%> (-0.21%) ⬇️
server/leader.go 83.26% <0%> (+1.22%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d9175...a4432b0. Read the comment docs.

@lhy1024
Copy link
Contributor

lhy1024 commented Jan 7, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

Your auto merge job has been accepted, waiting for 2083

@sre-bot
Copy link
Contributor Author

sre-bot commented Jan 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit d66345e into tikv:release-3.1 Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants