Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

location-labels does not support Backslash symbols #1588

Closed
xiaojingchen opened this issue Jun 20, 2019 · 3 comments · Fixed by #1595
Closed

location-labels does not support Backslash symbols #1588

xiaojingchen opened this issue Jun 20, 2019 · 3 comments · Fixed by #1595
Assignees
@shafreeck
Labels
component/schedule Scheduling logic. type/enhancement The issue belongs to an enhancement.

Comments

@xiaojingchen
Copy link

xiaojingchen commented Jun 20, 2019 •
edited
Loading

  1. What did you do?
    When I deploy TiDB cluster by TiDB operator on K8s, I want to use the labels which have been set in K8s node, but current PD does not support label which contains \.
    e.g:failure-domain.beta.kubernetes.io/region

  2. What did you expect to see?
    PD supports the label which matches K8s's label style.
    ref: https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/
@xiaojingchen xiaojingchen changed the title location-labels does not support Backslash symbols location-labels does not support Backslash symbols Jun 20, 2019
@shafreeck shafreeck self-assigned this Jun 21, 2019
@shafreeck
Copy link
Contributor

Thanks for your feedback, I will check about this.

@nolouch nolouch added component/schedule Scheduling logic. type/enhancement The issue belongs to an enhancement. labels Jun 21, 2019
@shafreeck
Copy link
Contributor

related: #1154

shafreeck added a commit to shafreeck/pd that referenced this issue Jun 24, 2019
@shafreeck
feature(label): tolerate backslash in the label name
bf017d9 
Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

Closes tikv#1588
@shafreeck shafreeck mentioned this issue Jun 24, 2019
Merged
@shafreeck
Copy link
Contributor

the k8s style: https://github.com/kubernetes/apimachinery/blob/master/pkg/util/validation/validation.go#L42

sre-bot pushed a commit to sre-bot/pd that referenced this issue Jan 7, 2020
@shafreeck @sre-bot
feature(label): tolerate backslash in the label name
8be9044 
Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

Closes tikv#1588
@sre-bot sre-bot mentioned this issue Jan 7, 2020
Merged
sre-bot pushed a commit to sre-bot/pd that referenced this issue Jan 7, 2020
@shafreeck @sre-bot
feature(label): tolerate backslash in the label name
5ff083d 
Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

Closes tikv#1588
@sre-bot sre-bot mentioned this issue Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shafreeck shafreeck

Labels
component/schedule Scheduling logic. type/enhancement The issue belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: tolerate backslash in the label name shafreeck/pd
3 participants
@shafreeck @xiaojingchen @nolouch