config: fix schedulers maybe lost after restarting #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
added
type/bug
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
force-pushed
the
schedulers-config
branch
from
0db4138
to
02171fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #2154 +/- ##
==========================================
+ Coverage 76.01% 76.24% +0.22%
==========================================
Files 195 195
Lines 20603 20626 +23
==========================================
+ Hits 15662 15726 +64
+ Misses 3743 3713 -30
+ Partials 1198 1187 -11
Continue to review full report at Codecov.
|
overvenus
approved these changes
Feb 27, 2020
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@rleungx merge failed. |
|
/run-all-tests |
|
/build |
|
|
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When we enable dynamic config, if we use pd-ctl to add a scheduler, it won't update the config manager and it will be lost after restarting. It should be reviewed after #2153 is merged.
What is changed and how it works?
This PR adds a callback function to update the config manager to solve the above problem.
Check List
Tests