Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #2454 to release-4.0 #2457

Merged
merged 4 commits into from
May 27, 2020
Merged

Cherry pick #2454 to release-4.0 #2457

merged 4 commits into from
May 27, 2020

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented May 26, 2020

What problem does this PR solve?

Cherry pick #2454 to release-4.0

What is changed and how it works?

TiDB Dashboard.

Check List

Tests

  • Manual test

Release note

Support setting public path for the embedded Dashboard.

Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish breezewish added this to the v4.0.0-ga milestone May 26, 2020
@jebter
Copy link
Collaborator

jebter commented May 26, 2020

/run-all-tests

Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish
Copy link
Member Author

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2457 into release-4.0 will increase coverage by 0.56%.
The diff coverage is 82.62%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2457      +/-   ##
===============================================
+ Coverage        76.42%   76.99%   +0.56%     
===============================================
  Files              206      205       -1     
  Lines            21958    21936      -22     
===============================================
+ Hits             16782    16889     +107     
+ Misses            3905     3752     -153     
- Partials          1271     1295      +24     
Impacted Files Coverage Δ
client/metrics.go 100.00% <ø> (ø)
pkg/apiutil/serverapi/middleware.go 73.07% <ø> (+2.70%) ⬆️
server/schedule/operator_controller.go 81.00% <ø> (ø)
server/server.go 77.53% <0.00%> (-0.35%) ⬇️
server/util.go 50.00% <0.00%> (-1.20%) ⬇️
tests/cluster.go 86.74% <ø> (+0.65%) ⬆️
tests/pdctl/helper.go 100.00% <ø> (ø)
pkg/component/manager.go 81.01% <25.00%> (-6.83%) ⬇️
server/api/region.go 73.83% <40.00%> (-0.72%) ⬇️
tools/pd-ctl/pdctl/command/config_command.go 72.01% <60.00%> (-0.52%) ⬇️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2303e3a...30aaf48. Read the comment docs.

@breezewish
Copy link
Member Author

/run-all-tests

@jebter
Copy link
Collaborator

jebter commented May 27, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 27, 2020

/run-all-tests

@jebter jebter merged commit 56d4c3d into release-4.0 May 27, 2020
@jebter jebter deleted the update-dashboard/0526 branch May 27, 2020 02:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants