[DNM] travis: add goveralls #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed @huachaohuang |
|
Changes Unknown when pulling c490e13 on huachaohuang/add-coveralls into * on master*. |
|
@huachaohuang |
|
Changes Unknown when pulling 0c2ab09 on huachaohuang/add-coveralls into * on master*. |
|
PTAL @overvenus |
overvenus
approved these changes
Oct 18, 2016
| @@ -4,6 +4,7 @@ PACKAGES := $$(go list ./...| grep -vE 'vendor') | |||
|
|
|||
| GOFILTER := grep -vE 'vendor|render.Delims|bindata_assetfs|testutil' | |||
| GOCHECKER := $(GOFILTER) | awk '{ print } END { if (NR > 0) { exit 1 } }' | |||
| GOVERSION := $(shell go version | awk '{ printf "%5.5s", $$3 }') | |||
There was a problem hiding this comment.
GOVERSION should be go1.7, but I got go ve%.
OS: ubuntu 14 LTS
awk: 1.2
neil:~/ $ go version | awk '{ printf "%5.5s", $$3 }'
go ve%
There was a problem hiding this comment.
If you run in console, you should use
go version | awk '{ printf "%5.5s", $3 }'
overvenus
reviewed
Oct 18, 2016
|
|
||
| script: | ||
| - make dev | ||
| - make coverage |
There was a problem hiding this comment.
Maybe we can use matrix.
matrix:
include:
- go: 1.7
script:
- make dev
after_success:
- make coverage
There was a problem hiding this comment.
I think we can remove make coverage and use the command directly here.
There was a problem hiding this comment.
Cool, can you open another PR to try it out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference https://coveralls.io/github/pingcap/pd.