-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] travis: add goveralls #345
Conversation
CI failed @huachaohuang |
Changes Unknown when pulling c490e13 on huachaohuang/add-coveralls into * on master*. |
@huachaohuang |
Changes Unknown when pulling 0c2ab09 on huachaohuang/add-coveralls into * on master*. |
PTAL @overvenus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it seems work, but I have a question as below.
@@ -4,6 +4,7 @@ PACKAGES := $$(go list ./...| grep -vE 'vendor') | |||
|
|||
GOFILTER := grep -vE 'vendor|render.Delims|bindata_assetfs|testutil' | |||
GOCHECKER := $(GOFILTER) | awk '{ print } END { if (NR > 0) { exit 1 } }' | |||
GOVERSION := $(shell go version | awk '{ printf "%5.5s", $$3 }') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOVERSION
should be go1.7
, but I got go ve%
.
OS: ubuntu 14 LTS
awk: 1.2
neil:~/ $ go version | awk '{ printf "%5.5s", $$3 }'
go ve%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run in console, you should use
go version | awk '{ printf "%5.5s", $3 }'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks!
|
||
script: | ||
- make dev | ||
- make coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can use matrix.
matrix:
include:
- go: 1.7
script:
- make dev
after_success:
- make coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove make coverage
and use the command directly here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, can you open another PR to try it out?
Reference https://coveralls.io/github/pingcap/pd.