server/resource: replace score type with resource kind #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huachaohuang
force-pushed
the
huachao/resource-score
branch
from
1fa7243
to
68b081e
Compare
huachaohuang
changed the title
I think the score things are too complicated, we can calculate the scores more easily.
huachaohuang
force-pushed
the
huachao/resource-score
branch
from
68b081e
to
e3b0759
Compare
|
PTAL @siddontang @overvenus |
siddontang
reviewed
Nov 22, 2016
|
|
||
| // Check diff score. | ||
| diff := source.resourceRatio(cb.kind) - target.resourceRatio(cb.kind) | ||
| if diff < cb.cfg.MaxDiffScoreFraction { |
There was a problem hiding this comment.
Yes, some configs are confusing, I will change them later.
siddontang
reviewed
Nov 25, 2016
| } | ||
|
|
||
| type leaderBalancer struct { | ||
| cfg *BalanceConfig | ||
| st scoreType | ||
| kind ResourceKind |
There was a problem hiding this comment.
can we use leaderKind directly in leaderBalancer?
There was a problem hiding this comment.
Then we need to type it in different places :(
siddontang
reviewed
Nov 25, 2016
| } | ||
| if maxUsedRatio < s.usedRatio() { | ||
| maxUsedRatio = s.usedRatio() | ||
| } | ||
| if minLeaderRatio > s.leaderRatio() { | ||
| minLeaderRatio = s.leaderRatio() | ||
| } | ||
| if maxLeaderRatio < s.leaderRatio() { | ||
| maxLeaderRatio = s.leaderRatio() |
There was a problem hiding this comment.
no need to check min == max ?
There was a problem hiding this comment.
No, it's OK if min == max, it means we balance very well.
|
Rest LGTM The code looks more clean now, but should improve the test coverage. PTAL @overvenus |
huachaohuang
added a commit
that referenced
this pull request
Nov 27, 2016
* server/resource: replace score type with resource kind I think the score things are too complicated, we can calculate the scores more easily.
huachaohuang
added a commit
that referenced
this pull request
Nov 28, 2016
* server/resource: replace score type with resource kind I think the score things are too complicated, we can calculate the scores more easily.
huachaohuang
added a commit
that referenced
this pull request
Nov 29, 2016
* server/resource: replace score type with resource kind I think the score things are too complicated, we can calculate the scores more easily.
huachaohuang
added a commit
that referenced
this pull request
Dec 1, 2016
* server/resource: replace score type with resource kind I think the score things are too complicated, we can calculate the scores more easily.
huachaohuang
added a commit
that referenced
this pull request
Dec 7, 2016
* server/resource: replace score type with resource kind I think the score things are too complicated, we can calculate the scores more easily.
huachaohuang
added a commit
that referenced
this pull request
Dec 8, 2016
* server/resource: replace score type with resource kind I think the score things are too complicated, we can calculate the scores more easily.
huachaohuang
added a commit
that referenced
this pull request
Dec 8, 2016
* server/selector: add selector interface and balance selector (#388) We can use selector to abstract different strategies to select the source and target stores. * server: use selector to schedule region peer (#389) * server/resource: replace score type with resource kind (#393) I think the score things are too complicated, we can calculate the scores more easily. * server/metrics: remove redundant metrics (#395) * server/balancer: add scheduler and simplify schedule configs (#396) The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores. * server/coordinator: replace balancer worker with coordinator (#398) Coordinator can control the speed of different schedulers. Every scheduler has a unique name, we can add API to run or stop any schedulers dynamically, and different schedulers can run concurrently. * server/constraints: add replication constraints (#402) * server/scheduler: add grant-leader-scheduler (#406) * server/coordinator: combine scheduler and controller * server/api: add scheduler api (#407) We can now use API to list all schedulers, add or remove a scheduler. * Add shuffle-leader-scheduler (#409) * server/scheduler: add shuffle-leader-scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the scorers are too complicated, we can calculate the scores very easily.