server/scheduler: add grant-leader-scheduler #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Dec 1, 2016
| @@ -39,6 +39,9 @@ type coordinator struct { | |||
| opt *scheduleOption | |||
| checker *replicaChecker | |||
|
|
|||
| schedulers map[string]Scheduler | |||
There was a problem hiding this comment.
I think we can use a ScheduleController interface
type ScheduleController interface {
Scheduler
Controller
}
huachaohuang
force-pushed
the
huachao/labels
branch
from
9ca675f
to
21a0191
Compare
huachaohuang
force-pushed
the
huachao/grant-leader-scheduler
branch
from
20dc513
to
a745901
Compare
|
|
huachaohuang
force-pushed
the
huachao/labels
branch
from
e0f0ae0
to
e9bf3bb
Compare
I think the score things are too complicated, we can calculate the scores more easily.
I think the score things are too complicated, we can calculate the scores more easily.
Coordinator can control the speed of different schedulers. Every scheduler has a unique name, we can add API to run or stop any schedulers dynamically, and different schedulers can run concurrently.
I think the score things are too complicated, we can calculate the scores more easily.
Coordinator can control the speed of different schedulers. Every scheduler has a unique name, we can add API to run or stop any schedulers dynamically, and different schedulers can run concurrently.
We can add and remove schedulers in coordinator dynamically.
huachaohuang
force-pushed
the
huachao/grant-leader-scheduler
branch
from
b7580b8
to
88a27bb
Compare
huachaohuang
changed the title
|
PTAL @siddontang @overvenus |
1 similar comment
|
PTAL @siddontang @overvenus |
|
LGTM |
huachaohuang
added a commit
that referenced
this pull request
Dec 8, 2016
* server/coordinator: combine scheduler and controller
huachaohuang
added a commit
that referenced
this pull request
Dec 8, 2016
* server/selector: add selector interface and balance selector (#388) We can use selector to abstract different strategies to select the source and target stores. * server: use selector to schedule region peer (#389) * server/resource: replace score type with resource kind (#393) I think the score things are too complicated, we can calculate the scores more easily. * server/metrics: remove redundant metrics (#395) * server/balancer: add scheduler and simplify schedule configs (#396) The original balance configs are complicated and some of them are very confusing, now we simplify them to make it more easy to understand. We replace the concept of "balance" with "schedule". Balance means to keep the resource balance, but we will introduce different kinds of strategies in the future which may not balance, and balance is just one kind of strategies to schedule resources between stores. * server/coordinator: replace balancer worker with coordinator (#398) Coordinator can control the speed of different schedulers. Every scheduler has a unique name, we can add API to run or stop any schedulers dynamically, and different schedulers can run concurrently. * server/constraints: add replication constraints (#402) * server/scheduler: add grant-leader-scheduler (#406) * server/coordinator: combine scheduler and controller * server/api: add scheduler api (#407) We can now use API to list all schedulers, add or remove a scheduler. * Add shuffle-leader-scheduler (#409) * server/scheduler: add shuffle-leader-scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine
SchedulerandControllerintoScheduleController.