-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/config: add etcd config #562
Conversation
How can we get these from TOML file? |
we will parse it firstly https://github.com/pingcap/pd/blob/master/server/config.go#L167 |
Use 1h for default AutoCompactionRetention |
server/config.go
Outdated
@@ -70,6 +70,10 @@ type Config struct { | |||
|
|||
Replication ReplicationConfig `toml:"replication" json:"replication"` | |||
|
|||
// Etcd config | |||
QuotaBackendBytes typeutil.ByteSize `toml:"quota-backend-bytes" json:"quota-backend-bytes"` | |||
AutoCompactionRetention int `toml:"auto-compaction-retention" json:"auto-compaction-retention"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some comments for the 2 configs.
LGTM |
CI failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PTAL @siddontang @disksing
close #561