Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always pull the old value internally #2301

Closed
hi-rustin opened this issue Jul 16, 2021 · 3 comments
Closed

always pull the old value internally #2301

hi-rustin opened this issue Jul 16, 2021 · 3 comments
Assignees
Labels
component/puller Puller component. component/sink Sink component. difficulty/medium Medium task. subject/new-feature Denotes an issue or pull request adding a new feature.

Comments

@hi-rustin
Copy link
Member

Feature Request

Is your feature request related to a problem? Please describe:

Because our new collation feature needs the old value to work properly. However, some users will not use old value, but may use new collation, so it needs to be configured by the user. (Users don't even know if they have new collation on)

To simplify this configuration and to make it easier for the user, we decided to:

1. always use old value internally.
2. the data output to the user needs to be in the correct format (without the old value configuration on, the old value cannot be output)

Describe the feature you'd like:
ticdc always pull the old value internally.

Describe alternatives you've considered:
None

@hi-rustin hi-rustin added the subject/new-feature Denotes an issue or pull request adding a new feature. label Jul 16, 2021
@hi-rustin hi-rustin self-assigned this Jul 16, 2021
@hi-rustin hi-rustin added component/puller Puller component. component/sink Sink component. difficulty/medium Medium task. labels Jul 16, 2021
@hi-rustin
Copy link
Member Author

hi-rustin commented Jul 16, 2021

@hi-rustin
Copy link
Member Author

cc: #2073

This seems to be the same requirement? @pepezzzz

@amyangfei
Copy link
Contributor

Closed by #2367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/puller Puller component. component/sink Sink component. difficulty/medium Medium task. subject/new-feature Denotes an issue or pull request adding a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants