Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter: remove file sorter (#2114) #2326

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2114

What problem does this PR solve?

  • File sorter has not been maintained and tested for a long time, and no one we know of uses it in production.

What is changed and how it works?

  • Removed file sorter.
  • For compatibility of running changefeeds, we use Unified Sorter in place when the user has previously set sort-engine to file.
  • The CLI will refuse the set sort-engine to file.

Check List

Tests

  • Integration test

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Remove file sorter.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jul 19, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 20, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@26adda2). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #2326   +/-   ##
================================================
  Coverage               ?   55.5742%           
================================================
  Files                  ?        165           
  Lines                  ?      19617           
  Branches               ?          0           
================================================
  Hits                   ?      10902           
  Misses                 ?       7665           
  Partials               ?       1050           

@amyangfei amyangfei added this to the v5.0.4 milestone Jul 21, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: fafff9a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests
/run-leak-tests
/run-unit-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 9f82ec6 into pingcap:release-5.0 Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants