Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add more metrics about kv client and gRPC stream (#2686) #2735

Merged
merged 6 commits into from
Sep 7, 2021
Merged

metrics: add more metrics about kv client and gRPC stream (#2686) #2735

merged 6 commits into from
Sep 7, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2686

What problem does this PR solve?

Add three more metrics in kv client.

What is changed and how it works?

  • Metric KV client scanning regions using ticdc_kvclient_region_token will help us to distinguish whether there is incremental scan ongoing.
  • Metric Active stream count of each gRPC connection using ticdc_kvclient_grpc_stream_count will help us to find gRPC stream distribution among all TiKV stores.
  • Add event type ("received" and "dropped") in metric Event size percentile to help us know how many events are dropped.

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@amyangfei @ti-chi-bot
This is an automated cherry-pick of pingcap#2686
03c6dd2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. component/metrics-logging Metrics and logging component. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Sep 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
@amyangfei amyangfei added this to the v5.2.1 milestone Sep 3, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 6, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 6cd5f5e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests
/run-unit-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests
/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-kafka-tests
/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

10 similar comments
@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@5e43787). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #2735   +/-   ##
================================================
  Coverage               ?   55.9295%           
================================================
  Files                  ?        169           
  Lines                  ?      20676           
  Branches               ?          0           
================================================
  Hits                   ?      11564           
  Misses                 ?       8006           
  Partials               ?       1106

@ti-chi-bot ti-chi-bot merged commit 829ec6f into pingcap:release-5.2 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees

@amyangfei amyangfei

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @amyangfei @codecov-commenter @nongfushanquan