Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: support interactive cmd #351

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Conversation

5kbpers
Copy link
Contributor

@5kbpers 5kbpers commented Mar 19, 2020

Signed-off-by: 5kbpers tangminghua@pingcap.com

What problem does this PR solve?

Current cli is not user-friendly enough.

What is changed and how it works?

Support interactive cli cmd and mark some flags required.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    image

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT1 status/ptal Could you please take a look? labels Mar 19, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@amyangfei
Copy link
Contributor

/run-integration-tests

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei
Copy link
Contributor

Good Job!

@amyangfei amyangfei added LGT2 and removed LGT1 labels Mar 19, 2020
@amyangfei amyangfei merged commit abccd4c into pingcap:master Mar 19, 2020
5kbpers added a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
* cli: support interactive cmd

Signed-off-by: 5kbpers <tangminghua@pingcap.com>

* make check

Signed-off-by: 5kbpers <tangminghua@pingcap.com>
amyangfei added a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
…ngcap#351)

* e2e: add one more fake job test, to prepare for node failure test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants