Add retry to gRPC stream client getter #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
type/bugfix
|
/run-integration-tests |
amyangfei
force-pushed
the
get-conn-retry
branch
from
83ae4b8
to
ff737e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
================================================
+ Coverage 29.2417% 31.2643% +2.0226%
================================================
Files 59 60 +1
Lines 5328 5655 +327
================================================
+ Hits 1558 1768 +210
- Misses 3629 3730 +101
- Partials 141 157 +16 |
|
/run-integration-tests |
zier-one
reviewed
Mar 28, 2020
| log.Warn("get grpc stream client failed", zap.Error(err)) | ||
| bo := tikv.NewBackoffer(ctx, tikvRequestMaxBackoff) | ||
| c.regionCache.OnSendFail(bo, rpcCtx, needReloadRegion(sri.failStoreIDs, rpcCtx), err) | ||
| continue MainLoop |
There was a problem hiding this comment.
if tikv is not active, will we fall into an endless loop?
There was a problem hiding this comment.
c.regionCache.OnSendFail(bo, rpcCtx, needReloadRegion(sri.failStoreIDs, rpcCtx), err) has set this tikv as failed store
There was a problem hiding this comment.
What happens if the server is all down?
There was a problem hiding this comment.
cdc retries to connect to tikv until some TiKVs are up and the cluster is available
There was a problem hiding this comment.
In fact this error only happens when gRPC connection is not established, which means at the CDC startup procedure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #387
What is changed and how it works?
dispatchRequestwhen getting stream client failed.Check List
Tests