cancel to generate ui library #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breezewish
reviewed
Jul 14, 2020
| getBabelLoader, | ||
| } = require('customize-cra') | ||
| const addYaml = require('react-app-rewire-yaml') | ||
| const { alias, configPaths } = require('react-app-rewire-alias') | ||
| const webpack = require('webpack') | ||
| const WebpackBar = require('webpackbar') | ||
| const nodeExternals = require('webpack-node-externals') |
There was a problem hiding this comment.
dependencies can be cleaned up as well
There was a problem hiding this comment.
Yep, will do it soon.
breezewish
approved these changes
Jul 14, 2020
ti-srebot
approved these changes
Jul 14, 2020
breezewish
added a commit
that referenced
this pull request
Jul 15, 2020
* ui: Fix TiFlash log searching (#680) * ui: Add a whitelist in i18next to fix the issue #675 (#677) * docs: add ericsyh as a contributor (#681) * ui: refine code and error handle (#662) * *: Rename disable_telemetry to enable_telemetry (#684) * ui: Update space behaviour in statement / slow log search (#682) * ui: No need to generate ui library (#687) * forwarder: evict invalid current picked remote (#689) * keyviz: support to merge cold logical range (#674) * Update release version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #685
Remove all codes about generating ui library since we don't need it anymore.