refactor 'Report a bug' part #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyangyu
force-pushed
the
refactor-report-issue
branch
2 times, most recently
from
63732eb
to
b514c1c
Compare
xxchan
reviewed
Sep 7, 2021
xxchan
reviewed
Sep 7, 2021
| 3. What did you see instead? | ||
| 4. What is your TiDB version? | ||
|
|
||
| For minimal reproduce step, it would be better to provide an executable SQL script, take [pingcap/tidb#25007](https://github.com/pingcap/tidb/issues/25007) as an example: |
There was a problem hiding this comment.
My intention is that not all issues are about SQL. If you think this example is useful and helpful for you, I'm totally okay to add it back.
zhangyangyu
force-pushed
the
refactor-report-issue
branch
4 times, most recently
from
04cb96f
to
5aeb478
Compare
zhangyangyu
force-pushed
the
refactor-report-issue
branch
from
5aeb478
to
19764d1
Compare
tisonkun
reviewed
Sep 13, 2021
tisonkun
reviewed
Sep 13, 2021
tisonkun
reviewed
Sep 13, 2021
tisonkun
reviewed
Sep 13, 2021
tisonkun
reviewed
Sep 13, 2021
tisonkun
reviewed
Sep 13, 2021
tisonkun
reviewed
Sep 13, 2021
There was a problem hiding this comment.
Thanks for refactoring this section @zhangyangyu ! Comments inline.
Co-authored-by: tison <wander4096@gmail.com>
|
Thanks @tisonkun for your eagle-eyed reviews! I've addressed the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR solve?
What is changed: