Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add privilege management #68

Merged
merged 5 commits into from Aug 10, 2021
Merged

Add privilege management #68

merged 5 commits into from Aug 10, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Aug 3, 2021

What issue does this PR solve?

What is changed:

Adds docs for privilege management.

@morgo
Copy link
Contributor Author

morgo commented Aug 3, 2021

cc @bb7133 @tisonkun

@tisonkun
Copy link
Contributor

tisonkun commented Aug 4, 2021

Thanks for submitting this PR. Will review by the end of tomorrow.

tisonkun
tisonkun reviewed Aug 5, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @morgo ! Comments inline.

Besides, what about we list all design documents and other related reading resource in a separated section at the end?

src/understand-tidb/privilege-management.md Outdated Show resolved Hide resolved
src/understand-tidb/privilege-management.md Show resolved Hide resolved
tisonkun
tisonkun approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@tisonkun
Copy link
Contributor

tisonkun commented Aug 8, 2021

cc @bb7133 @mjonss could you give this PR another review?

mjonss
mjonss reviewed Aug 8, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions, otherwise LGTM!

src/understand-tidb/privilege-management.md Outdated Show resolved Hide resolved
src/understand-tidb/privilege-management.md Outdated Show resolved Hide resolved
@morgo
Copy link
Contributor Author

morgo commented Aug 8, 2021

@bb7133 @mjonss feedback incorporated, PTAL again. Thx :-)

mjonss
mjonss approved these changes Aug 8, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
Copy link
Contributor

tisonkun commented Aug 9, 2021

Thanks for your collaborations! @bb7133 could you to give this PR a final check? Otherwise I'm going to merge this chapter tomorrow.

@tisonkun
Copy link
Contributor

Merging...Thanks for your contribution @morgo !

@tisonkun tisonkun merged commit 8369523 into pingcap:master Aug 10, 2021
@tisonkun
Copy link
Contributor

@all-contributors please add @morgo for content

@allcontributors allcontributors bot mentioned this pull request Aug 10, 2021
Merged
@allcontributors
Copy link
Contributor

@tisonkun

I've put up a pull request to add @morgo! 🎉

tisonkun added a commit to tisonkun/tidb-dev-guide that referenced this pull request Aug 13, 2021
@morgo @tisonkun
Add privilege management (pingcap#68)
d99667e 
* Add privilege management

* Update src/understand-tidb/privilege-management.md

Co-authored-by: tison <wander4096@gmail.com>

* Add feedback from reviewer

* Address feedback from reviewers

Co-authored-by: tison <wander4096@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@feitian124 feitian124 feitian124 left review comments

@tisonkun tisonkun tisonkun approved these changes

@mjonss mjonss mjonss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write down the first version of Privilege section
5 participants
@morgo @tisonkun @bb7133 @feitian124 @mjonss