Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker binlog #65

Merged
merged 6 commits into from May 20, 2019
Merged

Docker binlog #65

merged 6 commits into from May 20, 2019

Conversation

nange
Copy link
Contributor

@nange nange commented May 12, 2019

add binlog support.

@nange
Copy link
Contributor Author

nange commented May 15, 2019

Anyone could have a look? maybe @tennix ?

@tennix
Copy link
Member

tennix commented May 15, 2019

@nange OK, thanks for your contribution. PTAL @DanielZhangQD

compose/templates/docker-compose.yml Show resolved Hide resolved
docker-compose-binlog.yaml Outdated Show resolved Hide resolved
@nange
Copy link
Contributor Author

nange commented May 17, 2019

@DanielZhangQD All the issues you mentioned have been resolved. I'll handle docker swarm case in another pr.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants