Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

local: return error if write to tikv returns no leader info #381

Merged
merged 2 commits into from
Aug 31, 2020
Merged

local: return error if write to tikv returns no leader info #381

merged 2 commits into from
Aug 31, 2020

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Aug 31, 2020

What problem does this PR solve?

  • return an error if write to tikv finished with no leader info returned
  • fix an error if write and ingest all retry failed will just treat it as success

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Related changes

@glorv glorv requested a review from kennytm August 31, 2020 03:14
@3pointer
Copy link
Contributor

LGTM

@kennytm kennytm added the status/LGT1 One reviewer already commented LGTM (LGTM1) label Aug 31, 2020
kennytm
kennytm approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glorv glorv added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Aug 31, 2020
@glorv glorv merged commit ee94dc5 into master Aug 31, 2020
@glorv glorv deleted the fix-no-region branch August 31, 2020 06:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glorv @3pointer @kennytm