stage for backup CR looks confusing

[lichunzhu]

Question

tidb-operator/cmd/backup-manager/app/backup/manager.go

Line 146 in 697fd25

Type: v1alpha1.BackupRunning,

tidb-operator/cmd/backup-manager/app/backup/manager.go

Line 170 in 697fd25

Type: v1alpha1.BackupPrepare,

We set backup(br) job's status from Running -> Prepare -> Completed, which looks very confusing.

tidb-operator/cmd/backup-manager/app/export/manager.go

Line 157 in 697fd25

Type: v1alpha1.BackupRunning,

tidb-operator/cmd/backup-manager/app/export/manager.go

Line 341 in 697fd25

Type: v1alpha1.BackupPrepare,

It looks the same for export(dumpling) job.

[lichunzhu]

Suggest changing to Prepare -> Running -> Completed

[liubog2008]

@DanielZhangQD Just exchange Prepare and Running? Are there any problems of API meaning changes?

[DanielZhangQD]

@DanielZhangQD Just exchange Prepare and Running?

• Backup with BR
  • Prepare should be updated in https://github.com/pingcap/tidb-operator/blob/master/cmd/backup-manager/app/backup/manager.go#L183 block.
  • Running should be updated before the real backup https://github.com/pingcap/tidb-operator/blob/master/cmd/backup-manager/app/backup/manager.go#L264.
• Backup with Dumpling
  • Prepare should be updated before setting GC https://github.com/pingcap/tidb-operator/blob/master/cmd/backup-manager/app/export/manager.go#L165
  • Running before dumpling data https://github.com/pingcap/tidb-operator/blob/master/cmd/backup-manager/app/export/manager.go#L245.

Are there any problems of API meaning changes?

It's OK, this fix just changes the condition order in the CR status.

Test Cases:

• Backup with BR with spec.from configured
• Backup with BR without spec.from configured
• Backup with Dumpling