Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix backup stage order #3910

Merged
merged 2 commits into from Apr 13, 2021
Merged

fix backup stage order #3910

merged 2 commits into from Apr 13, 2021

Conversation

liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Apr 12, 2021 •
edited

What problem does this PR solve?

Closes #3904

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@liubog2008
Copy link
Member Author

@DanielZhangQD @handlerww PTAL

@DanielZhangQD
Copy link
Contributor

@liubog2008 Please update the test result in the PR description, there is no e2e test for backup now.

DanielZhangQD
DanielZhangQD reviewed Apr 12, 2021
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

DanielZhangQD
DanielZhangQD approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

csuzhangxc
csuzhangxc approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6fc0f74

@ti-chi-bot ti-chi-bot merged commit 63268cb into pingcap:master Apr 13, 2021
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Apr 13, 2021
@liubog2008 @ti-srebot
cherry pick pingcap#3910 to release-1.1
99a3214 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 13, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3913

@liubog2008 liubog2008 deleted the change-backup-stage branch April 13, 2021 05:39
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
fix backup stage order (#3910) (#3913)
b9189fe
@liubog2008
Copy link
Member Author

liubog2008 commented Apr 13, 2021 •
edited

Tests:

  • Backup with BR with spec.from configured
  • Backup with BR without spec.from configured
  • Backup with Dumpling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@handlerww handlerww Awaiting requested review from handlerww

@shuijing198799 shuijing198799 Awaiting requested review from shuijing198799

Assignees
No one assigned
Labels
needs-cherry-pick-1.1 status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stage for backup CR looks confusing
5 participants
@liubog2008 @DanielZhangQD @ti-chi-bot @ti-srebot @csuzhangxc