Fix stability PD Failover check #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
previously approved these changes
Jun 3, 2020
zjj2wry
reviewed
Jun 4, 2020
tests/failover.go
Outdated
| @@ -61,43 +61,74 @@ func (oa *operatorActions) DeletePDDataThenCheckFailover(info *TidbClusterConfig | |||
| } | |||
| klog.Infof("delete pod %s/%s data successfully", ns, podName) | |||
|
|
|||
| oldPD, err := oa.kubeCli.CoreV1().Pods(ns).Get(podName, metav1.GetOptions{}) | |||
| if err != nil { | |||
| klog.Error(err.Error()) | |||
cofyc
approved these changes
Jun 4, 2020
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/run-e2e-in-kind |
|
/run-e2e-tests |
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/run-e2e-in-kind |
|
/run-e2e-test |
|
/merge |
|
/run-all-tests |
|
@Yisaer merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb-operator
that referenced
this pull request
Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-1.1 in PR #2645 |
sre-bot
added a commit
that referenced
this pull request
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the pd failover check in stability test
Related changes
Does this PR introduce a user-facing change?: