Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly avoid broken aws 2.65.0 terraform provider #2688

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

kolbe
Copy link
Contributor

@kolbe kolbe commented Jun 11, 2020

What problem does this PR solve?

hashicorp/terraform-provider-aws#13626

root@3d1552defe47:/tidb-operator/deploy/aws# terraform apply
module.tidb-operator.module.eks.data.aws_caller_identity.current: Refreshing state...
module.tidb-operator.module.eks.data.aws_region.current: Refreshing state...
module.tidb-operator.module.eks.data.aws_iam_policy_document.workers_assume_role_policy: Refreshing state...
module.tidb-operator.module.eks.data.aws_iam_policy_document.cluster_assume_role_policy: Refreshing state...
module.tidb-operator.module.eks.data.aws_ami.eks_worker: Refreshing state...
module.vpc.data.aws_availability_zones.available: Refreshing state...
module.bastion.data.aws_ami.centos: Refreshing state...
Error: expected private_ip to contain a valid IPv4 address, got:
  on .terraform/modules/bastion.ec2/terraform-aws-ec2-instance-2.3.0/main.tf line 96, in resource "aws_instance" "this_t2":
  96: resource "aws_instance" "this_t2" {

What is changed and how does it work?

This patch simply tells terraform to avoid version 2.65.0 of the AWS provider.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Deploy worked fine after making this change.

Code changes

  • Has Terraform scripts change

I'm not sure if it's really a Terraform script change.

Side effects

Unknown.

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Jun 12, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 12, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 12, 2020

/run-all-tests

@sre-bot sre-bot merged commit 0a154fb into pingcap:master Jun 12, 2020
sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request Jun 12, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 12, 2020

cherry pick to release-1.1 in PR #2690

sre-bot added a commit that referenced this pull request Jun 12, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Kolbe Kegel <kolbe@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants