Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidbmonitor add additional volume configuration #3855

Merged
merged 2 commits into from Mar 17, 2021

Conversation

mikechengwei
Copy link
Contributor

What problem does this PR solve?

Add additional volume and volumeMount configuration.

Code changes

  • Has Go code change

Tests

  • Unit test
  • E2E test
  • Manual test

Release Notes

TidbMonitor add additional volume and volumeMount configurations.

@codecov-io
Copy link

codecov-io commented Mar 14, 2021

Codecov Report

Merging #3855 (c34fbbe) into master (83a34d5) will increase coverage by 0.87%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3855      +/-   ##
==========================================
+ Coverage   67.78%   68.65%   +0.87%     
==========================================
  Files         173      173              
  Lines       18449    18455       +6     
==========================================
+ Hits        12505    12670     +165     
+ Misses       4860     4682     -178     
- Partials     1084     1103      +19     
Flag Coverage Δ
e2e 42.76% <0.00%> (+2.65%) ⬆️
unittest 62.35% <0.00%> (-0.05%) ⬇️

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
@mikechengwei
Copy link
Contributor Author

/test pull-e2e-kind

@mikechengwei
Copy link
Contributor Author

/test pull-e2e-kind-serial

Copy link
Contributor

@handlerww handlerww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • handlerww
  • july2993

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@mikechengwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fe21edf

@ti-chi-bot ti-chi-bot merged commit 2f25af2 into pingcap:master Mar 17, 2021
shonge pushed a commit to shonge/tidb-operator that referenced this pull request Mar 30, 2021
shonge pushed a commit to shonge/tidb-operator that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants