Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Optimization PodsAreChanged function #3901

Merged
merged 3 commits into from Apr 12, 2021

Conversation

shonge
Copy link
Member

@shonge shonge commented Apr 7, 2021

What problem does this PR solve?

Close #3895

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Optimization PodsAreChanged function

@shonge
Copy link
Member Author

shonge commented Apr 7, 2021

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #3901 (8c3768b) into master (697fd25) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3901      +/-   ##
==========================================
+ Coverage   62.41%   62.42%   +0.01%     
==========================================
  Files         171      171              
  Lines       18134    18134              
==========================================
+ Hits        11318    11321       +3     
+ Misses       5718     5716       -2     
+ Partials     1098     1097       -1     
Flag Coverage Δ
unittest 62.42% <ø> (+0.01%) ⬆️

@shonge
Copy link
Member Author

shonge commented Apr 8, 2021

@DanielZhangQD PTAL

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8c3768b

@ti-chi-bot ti-chi-bot merged commit 8f2be25 into pingcap:master Apr 12, 2021
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Apr 12, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization for PodsAreChanged function
7 participants