Support NG Monitoring #4287
Support NG Monitoring #4287
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4287 +/- ##
==========================================
+ Coverage 61.61% 65.05% +3.43%
==========================================
Files 182 194 +12
Lines 19653 22529 +2876
==========================================
+ Hits 12110 14657 +2547
- Misses 6367 6603 +236
- Partials 1176 1269 +93
|
KanShiori
force-pushed
the
ng_monitor_cr
branch
from
7296e20
to
6763527
Compare
| @@ -74,30 +73,6 @@ func annotationsMountVolume() (corev1.VolumeMount, corev1.Volume) { | |||
| return m, v | |||
| } | |||
|
|
|||
| // statefulSetIsUpgrading confirms whether the statefulSet is upgrading phase | |||
| func statefulSetIsUpgrading(set *apps.StatefulSet) bool { | |||
There was a problem hiding this comment.
move some function to a public pkg pkg/manager/utils in order to reuse
|
/test pull-e2e-kind-br |
# Conflicts: # pkg/manager/member/tikv_upgrader.go
# Conflicts: # pkg/apis/pingcap/v1alpha1/openapi_generated.go
|
/test pull-e2e-kind |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 72cc593
|
|
/test pull-e2e-kind |
# Conflicts: # pkg/manager/member/tikv_upgrader.go
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: f1a38b6
|
|
/test pull-e2e-kind |
|
/test pull-e2e-kind-across-kubernetes |
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Unit test
E2E test
Manual test
No code
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.