Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config to increase kube-client qps limit #4830

Merged
merged 3 commits into from Jan 10, 2023

Conversation

Thearas
Copy link
Contributor

@Thearas Thearas commented Jan 9, 2023

What problem does this PR solve?

Close #4829.

What is changed and how does it work?

Add two config kubeClientQPS and kubeClientBurst, they will be passed to kube client-go config.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Support for configuring kube-client QPS and Burst: `kubeClientQPS`/`kubeClientBurst`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #4830 (2564d7a) into master (e17bccf) will decrease coverage by 17.14%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4830       +/-   ##
===========================================
- Coverage   59.99%   42.84%   -17.15%     
===========================================
  Files         224      204       -20     
  Lines       25354    25682      +328     
===========================================
- Hits        15211    11004     -4207     
- Misses       8703    13353     +4650     
+ Partials     1440     1325      -115     
Flag Coverage Δ
e2e 42.84% <100.00%> (?)
unittest ?

@Thearas Thearas marked this pull request as ready for review January 9, 2023 08:08
@Thearas Thearas changed the title [WIP] Add config to increase kube-client qps limit Add config to increase kube-client qps limit Jan 9, 2023
@Thearas
Copy link
Contributor Author

Thearas commented Jan 9, 2023

I test with -kube-client-qps=50 -kube-client-burst=100 and -kube-client-qps=0 -kube-client-burst=0 manually, both can work.
PTAL @csuzhangxc

charts/tidb-operator/values.yaml Outdated Show resolved Hide resolved
@csuzhangxc
Copy link
Member

@KanShiori PTAL

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2564d7a

@ti-chi-bot ti-chi-bot merged commit 703375a into pingcap:master Jan 10, 2023
@Thearas Thearas deleted the kube-qps branch January 10, 2023 03:50
@Thearas
Copy link
Contributor Author

Thearas commented Jan 10, 2023

Hi @csuzhangxc.
Can we cherry-pick this PR to the release-1.4 branch?

@csuzhangxc
Copy link
Member

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.4: #4834.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc added a commit that referenced this pull request Jan 12, 2023
Co-authored-by: Thearas <thearas850@gmail.com>
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase k8s client-go rate-limit qps
5 participants