New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix panic without PV permission #4837
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4837 +/- ##
==========================================
+ Coverage 59.99% 68.52% +8.53%
==========================================
Files 224 228 +4
Lines 25356 28428 +3072
==========================================
+ Hits 15212 19481 +4269
+ Misses 8704 7491 -1213
- Partials 1440 1456 +16
|
@@ -88,6 +88,11 @@ func (m *EBSModifier) Validate(spvc, dpvc *corev1.PersistentVolumeClaim, ssc, ds | |||
} | |||
|
|||
func (m *EBSModifier) ModifyVolume(ctx context.Context, pvc *corev1.PersistentVolumeClaim, pv *corev1.PersistentVolume, sc *storagev1.StorageClass) ( /*wait*/ bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment in the VolumeModifier
interface to note the pv
may be nil and the reason.
/test pull-e2e-kind |
/test pull-e2e-kind-serial |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7b0c25b
|
/test pull-e2e-kind-serial |
3 similar comments
/test pull-e2e-kind-serial |
/test pull-e2e-kind-serial |
/test pull-e2e-kind-serial |
/cherry-pick release-1.4 |
@csuzhangxc: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
fix #4797
NOTE, in this case, some volume statuses will not be updated
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.