Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm version to the 3.11.0 #4847

Merged
merged 4 commits into from
Mar 10, 2023
Merged

update helm version to the 3.11.0 #4847

merged 4 commits into from
Mar 10, 2023

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

What problem does this PR solve?

update helm to the latest: 3.11.0

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2023

CLA assistant check
All committers have signed the CLA.

@csuzhangxc
Copy link
Member

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #4847 (6c4f275) into master (b96b853) will increase coverage by 8.81%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4847      +/-   ##
==========================================
+ Coverage   59.00%   67.81%   +8.81%     
==========================================
  Files         227      231       +4     
  Lines       26357    29530    +3173     
==========================================
+ Hits        15551    20026    +4475     
+ Misses       9301     7962    -1339     
- Partials     1505     1542      +37     
Flag Coverage Δ
e2e 52.49% <ø> (?)
unittest 59.01% <ø> (+0.01%) ⬆️

@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-basic

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 42293d9

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

5 similar comments
@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

@yanggangtony some charts' version need to be updated.

e.g failed to deploy drainer [tidb-cluster-6777/tls], exit status 1, Error: INSTALLATION FAILED: validation: chart.metadata.version "dev" is invalid reported in pull-e2e-kind.

@csuzhangxc csuzhangxc self-requested a review March 6, 2023 08:18
@ti-chi-bot
Copy link
Member

@yanggangtony: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@yanggangtony
Copy link
Contributor Author

@csuzhangxc
thanks for review.

Is that ok to do next steps?
charts/tidb-drainer/Chart.yaml
charts/tidb-lightning/Chart.yaml
charts/tikv-importer/Chart.yaml

change the above file 's content from "version: dev" to "version: v1-canary"?

Signed-off-by: yanggang <gang.yang@daocloud.io>
@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/run-all-tests

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-serial

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

3 similar comments
@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/test pull-e2e-kind-across-kubernetes

@csuzhangxc
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6c4f275

@ti-chi-bot ti-chi-bot merged commit b01d2a5 into pingcap:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants