Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue tiflash metric server listen on incorrect addr when ipv6 enabled #4889

Merged
merged 4 commits into from Feb 23, 2023

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 20, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hanlins

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@KanShiori KanShiori changed the title Fix the issue tiflash metric server listen on incorrect addr for ipv6 enabled Fix the issue tiflash metric server listen on incorrect addr when ipv6 enabled Feb 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #4889 (8dc467f) into master (babb7d8) will increase coverage by 8.41%.
The diff coverage is 25.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4889      +/-   ##
==========================================
+ Coverage   59.36%   67.78%   +8.41%     
==========================================
  Files         226      230       +4     
  Lines       25717    28798    +3081     
==========================================
+ Hits        15268    19521    +4253     
+ Misses       8991     7807    -1184     
- Partials     1458     1470      +12     
Flag Coverage Δ
e2e 52.62% <25.00%> (?)
unittest 59.37% <25.00%> (+<0.01%) ⬆️

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Member

@KanShiori: once the present PR merges, I will cherry-pick it on top of release-1.4 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

1 similar comment
@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-basic

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-tikv-scale-simultaneously

Copy link
Contributor

@hanlins hanlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-serial pull-e2e-kind-basic pull-e2e-kind-across-kubernetes pull-e2e-kind

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind pull-e2e-kind-basic pull-e2e-kind-serial

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind-serial

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind 

@KanShiori
Copy link
Collaborator Author

/test pull-e2e-kind

@KanShiori KanShiori merged commit c874bb8 into pingcap:master Feb 23, 2023
@KanShiori KanShiori deleted the shiori/fix-metric-ipv6 branch February 23, 2023 06:07
@ti-chi-bot
Copy link
Member

@KanShiori: new pull request created to branch release-1.4: #4899.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants