New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue tiflash metric server listen on incorrect addr when ipv6 enabled #4889
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4889 +/- ##
==========================================
+ Coverage 59.36% 67.78% +8.41%
==========================================
Files 226 230 +4
Lines 25717 28798 +3081
==========================================
+ Hits 15268 19521 +4253
+ Misses 8991 7807 -1184
- Partials 1458 1470 +12
|
/test pull-e2e-kind pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously |
/test pull-e2e-kind pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously |
/test pull-e2e-kind |
/cherry-pick release-1.4 |
@KanShiori: once the present PR merges, I will cherry-pick it on top of release-1.4 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/test pull-e2e-kind |
1 similar comment
/test pull-e2e-kind |
/test pull-e2e-kind-basic |
/test pull-e2e-kind |
/test pull-e2e-kind-tikv-scale-simultaneously |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test pull-e2e-kind-tikv-scale-simultaneously pull-e2e-kind-serial pull-e2e-kind-basic pull-e2e-kind-across-kubernetes pull-e2e-kind |
/test pull-e2e-kind pull-e2e-kind-basic pull-e2e-kind-serial |
/test pull-e2e-kind-serial |
/test pull-e2e-kind |
/test pull-e2e-kind |
@KanShiori: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.