Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ebs): fix missing param in sc when modify ebs #4892

Merged
merged 1 commit into from Feb 21, 2023

Conversation

liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Feb 21, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #4892 (3afc380) into master (06f61e3) will increase coverage by 2.14%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4892      +/-   ##
==========================================
+ Coverage   59.43%   61.58%   +2.14%     
==========================================
  Files         226      230       +4     
  Lines       25694    28776    +3082     
==========================================
+ Hits        15272    17721    +2449     
- Misses       8966     9506     +540     
- Partials     1456     1549      +93     
Flag Coverage Δ
e2e 34.06% <0.00%> (?)
unittest 59.42% <0.00%> (-0.02%) ⬇️

@csuzhangxc
Copy link
Member

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic
/test pull-e2e-kind-br
/test pull-e2e-kind-tngm

@csuzhangxc csuzhangxc merged commit c4e1c3a into pingcap:master Feb 21, 2023
@csuzhangxc
Copy link
Member

/cherry-pick release-1.4

@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.4: #4893.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants